Continuing the completely random and unprioritized checklist. Some of them are easy to fix, some are heavy.
Eliminate mutable state where possible
Immutability has many advantages over mutable objects, none of them will I mention here. For an example see the Query class in the previous post. Avoid setters, use final keyword and defensive copies.
Thread safety
Quite self-explanatory.
Separation of concurrency and domain logic
Multi-threading logic should be separated from the rest of the code. It's quite complex on its own, even more when is intertwined with other things.
Invariants and UnitOfWork-s
Check what are the units of work, and what are the invariants. The formers should encapsulate the latter. This is quite an important point. And a not so low hanging fruit, probably.
Push third-party code to the outer layers
This might be a big one. Practically I think almost all application should follow the Hexagonal Architecture style. This can be achieved iteratively, but could take a long time to get there if the code hasn't been written that way.
To be continued...
No comments :
Post a Comment